ObjectWeb Consortium
Search ObjectWeb Mail Archive: 

Advanced Search - Powered by Google


Mail Archive Home | enhydra List | August 2004 Index

<--  Date Index  --> <--  Thread Index  -->

Re: [enhydra] Enhydra 5.1-15 released!


V Út, 31. 08. 2004 v 16:21, Sinisa Milosevic píše:
> We had problems with some of our demo samples (DemoApp and
> phoneBookSoap) with your patch, and we had to leave 'ap' string parameter
> as element of 'target' string initialization value!

This looks like my fault actually. The 'ap' must be there for
ClientPageRedirect to a subfolder. Sorry.

> Your suggestion:

Mine suggestion was important in two things:

1) there were two blocks of almost identical code (almost = I overlooked
the 'ap' in target) and I wanted to rejoin/unify/cleanup that since the
only difference was the in the Client/ServerPageRedirection.

2) I wanted to have documented my findings of the differences and
peculiarities of the two different redirections because I happened to
forgot them and had to reinvent them twice. That was the purpose of the
long text in the comments.

> Integrated implementation (left as is):
> 
>                 String target = "";
> 
>                 if (defaultUrl.startsWith("/")) {
>                     target += ap + defaultUrl.substring(1);
>                 } else {
>                     target += ap + defaultUrl;
>                 }

I never had an application that would need to redirect from "/" to a
subdir so that's why I missed the 'ap', sorry. I would think that the
target for ServerPageRedirect should not contain the 'ap' but I am not
interested in testing the code again. Having my explanation in the
comment there makes me happy enough.

Thanks

Petr





<--  Date Index  --> <--  Thread Index  -->

Reply via email to:

Powered by MHonArc.

Copyright © 1999-2005, ObjectWeb Consortium | contact | webmaster.